WarcraftReamls.com
  FAQFAQ    SearchSearch    MemberlistMemberlist    UsergroupsUsergroups   RegisterRegister 
  ProfileProfile    Log in to check your private messagesLog in to check your private messages    Log inLog in 
Armory Links 404

 
Post new topic   Reply to topic    WarcraftRealms.com Forum Index -> WarcraftRealms.com Bugs
View previous topic :: View next topic  
Author Message
Narlash
Census Taker


Joined: 20 Jun 2006
Posts: 36
Location: Sweden
WR Updates: 1,543,245
Narlash WR Profile

PostPosted: Sat Nov 15, 2014 5:12 am    Post subject: Armory Links 404 Reply with quote

Hey guys Smile Just a super minor annoyance, which shouldn't be too hard to fix.
Would it be possible for someone to change the Armory Link from a + (plus) to a - (hyphen)?

Take for instance my main character's profile Armory Link.
I play on a server with a space in its name, Emerald Dream:

The link Warcraft Realms produces to the armory is
Code:
http://us.battle.net/wow/en/character/Emerald+Dream/Milix/simple

This produces a 404 on the Armory.

A working link should be:
Code:
http://us.battle.net/wow/en/character/Emerald-Dream/Milix/simple


Just switch the plus out for a hyphen and we should be good Smile
Not a major issue, but it makes the site act a lot less broken.
Thanks! <3
Back to top
View user's profile Send private message Visit poster's website
FuxieDK
Census Taker


Joined: 22 May 2008
Posts: 621
Location: Copenhagen, DK
WR Updates: 4,420,719
FuxieDK WR Profile

PostPosted: Sat Nov 15, 2014 9:51 pm    Post subject: Reply with quote

.....if the link are being changed, PLEASE change "simple" to "advanced"..

I doubt anyone actually use simply viewing..
_________________
Doing census mainly on Draenor; Raluf - Nimsay - Lusmo - Quixx - Sosyan - Garthog - Trubin - Zalistra - Zesmi and Djaang
Back to top
View user's profile Send private message
bringoutyourdead
Forums Admin & general flunky


Joined: 07 Nov 2008
Posts: 1219
Location: Silicon Valley, CA, USA
WR Updates: 9,184,629
bringoutyourdead WR Profile

PostPosted: Sun Nov 16, 2014 8:27 pm    Post subject: Reply with quote

I am going to have to play with the code...
so be warned.. the link to the Blizzards character display (the armory) will be acting strangely for the next few hours.

It is important to remember that almost everything you see here is custom built on the fly coding.
About the only page that is pure static html is the censusplus.php page that points to the addon distributions.

Oddly enough the code that points to the armory is different for US and EU regions (why? I haven't a clue.)
US realms use php urlencode to handle special characters in server names.. and has /simple added on the end. This is displayed as 'Armory Profile'
EU realms don't have the encoding and have /advanced added on the end. This is displayed as 'Armory Link'

There appears to be a incompatibility issue with the way PHP handles the encoding and the way Apache webserver handles the encoding.
Back to top
View user's profile Send private message
bringoutyourdead
Forums Admin & general flunky


Joined: 07 Nov 2008
Posts: 1219
Location: Silicon Valley, CA, USA
WR Updates: 9,184,629
bringoutyourdead WR Profile

PostPosted: Sun Nov 16, 2014 9:31 pm    Post subject: Reply with quote

Sigh the appears to be damned if you do, and damned if you don't

SO I will be damned... I have removed the encoding to handle non-allowed items in a URL (specifically the space character).

We have 4 actors with their hands in the pie.

First we have the specification RFC 3986 which updates 1738 and obsoletes 3 other RFC specifications.

Second we have http servers such as Apache and others that take the html etc and respond to ...

Third the web browsers.. IE, Firefox, Chrome, Opera , etc.

And fourth we have PHP coding rules.


When you click on the link...
the Apache server here at Warcraftrealms.com sends the URL back to your browser with the coding that says the browser needs to act on that URL.
Your browser will do something with the link... but the vendors handle the URL differently.

For example
http://us.battle.net/wow/en/character/Area 52/Censushordta/advanced

the wr page produced has
href="http://us.battle.net/wow/en/character/Area 52/Deadwolfen/advanced" target="_blank">Armory Profile
clicking on that link in Firefox puts the same on the address bar.. but actually sends to us.battle.net the following
http://us.battle.net/wow/en/character/Area%2052/Censushordta/advanced

whereas IE handles it as follows
address bar: http://us.battle.net/wow/en/character/Area%2052/Censushordta/advanced
url requested: http://us.battle.net/wow/en/character/Area%2052/Censushordta/advanced

So firefox displays what it was given but requests per standard
IE modifies to standard the display and the request.


At some point in time I think Rollie ran into a browser that wasn't working with the space -> % 20 standard... instead it was using the space -> + variant.. which is what PHP also used as standard under the older standards.
Back to top
View user's profile Send private message
Narlash
Census Taker


Joined: 20 Jun 2006
Posts: 36
Location: Sweden
WR Updates: 1,543,245
Narlash WR Profile

PostPosted: Sun Nov 16, 2014 11:07 pm    Post subject: Reply with quote

Ho-ly crap! o.o
Well - It works now, so yay! Super much awesome internet points for you bringoutyourdead!!!!! You took one of the possibly most vainest of annoyances anyone could have and fixed it even though it was the most messiest of tasks. You sir, have won my ultimate respect and deepest gratitude.
Thank you!
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    WarcraftRealms.com Forum Index -> WarcraftRealms.com Bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
WarcraftRealms.com  


Powered by phpBB © 2001, 2005 phpBB Group